Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubmitEvent.submitter & FormData(form, submitter) #402

Merged
merged 9 commits into from
Jul 7, 2024

Conversation

filiphlm
Copy link
Contributor

Solves #401. No polyfill(s) included.

Copy link
Member

@jiripudil jiripudil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I really like how this simplifies things. I just have a few suggestions regarding the BC and ergonomics of the API

src/core/UIHandler.ts Show resolved Hide resolved
src/core/UIHandler.ts Outdated Show resolved Hide resolved
src/core/UIHandler.ts Outdated Show resolved Hide resolved
src/core/UIHandler.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.53%. Comparing base (509dbd6) to head (eeb868d).

Current head eeb868d differs from pull request most recent head 2255ac4

Please upload reports for the commit 2255ac4 to get more accurate results.

Files Patch % Lines
src/core/UIHandler.ts 82.60% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   94.29%   94.53%   +0.23%     
==========================================
  Files          11       11              
  Lines        1298     1262      -36     
  Branches      177      168       -9     
==========================================
- Hits         1224     1193      -31     
+ Misses         72       67       -5     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiripudil jiripudil merged commit 80e15ee into naja-js:main Jul 7, 2024
@jiripudil
Copy link
Member

Hi, sorry this took me so long. I've been having a downswing in terms of time and energy that I'm willing to dedicate to OSS recently.

While reviewing the code, I've had some more thoughts on how to improve its type safety. I took the liberty of implementing the ideas myself, because I didn't want you to have to wait another month for me to come back to this.

I really appreciate the good work you've put into this, and I'm looking forward to your future contributions!

@filiphlm filiphlm deleted the naja-formdata-submitter branch July 13, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants