-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SubmitEvent.submitter & FormData(form, submitter) #402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I really like how this simplifies things. I just have a few suggestions regarding the BC and ergonomics of the API
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 94.29% 94.53% +0.23%
==========================================
Files 11 11
Lines 1298 1262 -36
Branches 177 168 -9
==========================================
- Hits 1224 1193 -31
+ Misses 72 67 -5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Hi, sorry this took me so long. I've been having a downswing in terms of time and energy that I'm willing to dedicate to OSS recently. While reviewing the code, I've had some more thoughts on how to improve its type safety. I took the liberty of implementing the ideas myself, because I didn't want you to have to wait another month for me to come back to this. I really appreciate the good work you've put into this, and I'm looking forward to your future contributions! |
Solves #401. No polyfill(s) included.